Skip to content

feat: provide flexibility by default to the azure region#41

Merged
butler54 merged 1 commit intovalidatedpatterns:mainfrom
butler54:azure-region-flexibility
May 19, 2025
Merged

feat: provide flexibility by default to the azure region#41
butler54 merged 1 commit intovalidatedpatterns:mainfrom
butler54:azure-region-flexibility

Conversation

@butler54
Copy link
Collaborator

@butler54 butler54 commented May 11, 2025

Closes: #38

Signed-off-by: Chris Butler chris.butler@redhat.com

Signed-off-by: Chris Butler <chris.butler@redhat.com>
@butler54 butler54 requested review from sabre1041 and yuvalk May 11, 2025 23:49
@yuvalk yuvalk self-assigned this May 13, 2025
@yuvalk
Copy link
Collaborator

yuvalk commented May 13, 2025

lgtm

@yuvalk yuvalk self-requested a review May 13, 2025 01:36
@bpradipt
Copy link
Collaborator

looks good..
Looks like the linter is complaining for yaml files etc which might need to be fixed

Copy link
Collaborator

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A future enhancement would be to validate the region provided

@butler54 butler54 merged commit 296e83b into validatedpatterns:main May 19, 2025
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Azure region hardcoded to eastasia

4 participants